-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openPMD: Support for mesh refinement #1842
Conversation
After a little cleanup commit, I did more tests today (ADIOS2, HDF5) and the particles and fields look great, as well as particles transitioning between patches. I am double-checking with @RevathiJambunathan that the back-transformed diagnostics is still working and after that I think it can go in :) |
Thanks for this PR! I tested this for Back Transformed diagnostics and get an error:
Here is the input file |
Thanks I will take a look later today |
The crash is likely due to additional patch parts that should remain in #1909 for the transition to group & variable based I/O options. I'll clean them out and re-test. |
Would be great see why 1909 is not passing the CI. |
I removed the un-related streaming API changes from this PR. Let's also add BTD with openPMD to CI in a PR. |
Implements the openPMD mesh-refinement extension: openPMD/openPMD-standard#252
(future:
_<P>
patch number for HDF5 as a fallback)